lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 27 Jul 2013 12:26:27 +0200 From: Borislav Petkov <bp@...en8.de> To: "zhangwei(Jovi)" <jovi.zhangwei@...wei.com> Cc: Andrew Morton <akpm@...ux-foundation.org>, Ingo Molnar <mingo@...hat.com>, Dan Carpenter <dan.carpenter@...cle.com>, Steven Rostedt <rostedt@...dmis.org>, Jens Axboe <axboe@...nel.dk>, Al Viro <viro@...iv.linux.org.uk>, Eric Dumazet <edumazet@...gle.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] relay: fix timer madness v3 On Sat, Jul 27, 2013 at 03:04:43PM +0800, zhangwei(Jovi) wrote: > Changed from v2: > mod timer interval changed from HZ/10 to jiffies + HZ/10, > as Dan Carpenter suggested. > > This patch is based on -mm tree. This is one of those guess-what-I'm-thinking commit messages. Can you please write it this way: The situation currently is A, the bug is B, I'm fixing it by doing C. Don't be afraid to be more verbose. An innocent bystander can only guess why the change was done and I'm willing to bet good money that a couple of years from now, not even you will know why you did it. Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists