linux-kernel - Re: [ 06/79] net: Swap ver and type in pppoe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 27 Jul 2013 21:16:16 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Ben Hutchings <ben@...adent.org.uk>
Cc:	David Miller <davem@...emloft.net>, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [ 06/79] net: Swap ver and type in pppoe_hdr

On Sun, Jul 28, 2013 at 04:14:31AM +0100, Ben Hutchings wrote:
> On Sat, 2013-07-27 at 17:55 -0700, David Miller wrote:
> > From: Ben Hutchings <ben@...adent.org.uk>
> > Date: Sat, 27 Jul 2013 16:58:28 +0100
> > 
> > > I'm not so sure this is suitable for stable.  It doesn't seem to be
> > > helpful to either userland or kernel code.
> > > 
> > > In the kernel, we were checking that ver == 1 and type == 1 thus this
> > > wasn't hurting us.
> > > 
> > > If userland does anything more with these fields then it's probably
> > > already working around the swapped fields.  It can work with both old
> > > and new headers by doing:
> > 
> > It's up to you, I would rather have the corrected version propagated
> > as soon as possible.  But that's just me.
> 
> Let's see what Greg thinks.

I'm guessing that Linus's tree is also "wrong" here, correct?  If so,
the fix that goes into that tree should also go here as well.

Or am I confused?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/