linux-kernel - [PATCH] smp: kill unnecessary variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 29 Jul 2013 10:29:45 +0800
From:	Xie XiuQi <xiexiuqi@...wei.com>
To:	Jens Axboe <jens.axboe@...cle.com>, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
CC:	Hanjun Guo <guohanjun@...wei.com>, Li Zefan <lizefan@...wei.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: [PATCH] smp: kill unnecessary variable - csd_flags

We used csd_flags formerly because we allocated csd_data by
kmalloc when "wait == 0". When fail to allocation, we will
fall back to on-stack allocation. "csd_data" might be invalid
after generic_exec_single return.

But now we use per cpu data for single cpu ipi calls, and
csd_data can't fall back to on-stack allocation when "wait == 0".

So csd_flags is unnecessary now. Remove it.

Signed-off-by: Xie XiuQi <xiexiuqi@...wei.com>
---
 kernel/smp.c |   11 +----------
 1 files changed, 1 insertions(+), 10 deletions(-)

diff --git a/kernel/smp.c b/kernel/smp.c
index 4dba0f7..cac2b6e 100644
--- a/kernel/smp.c
+++ b/kernel/smp.c
@@ -186,25 +186,16 @@ void generic_smp_call_function_single_interrupt(void)

 	while (!list_empty(&list)) {
 		struct call_single_data *csd;
-		unsigned int csd_flags;

 		csd = list_entry(list.next, struct call_single_data, list);
 		list_del(&csd->list);

-		/*
-		 * 'csd' can be invalid after this call if flags == 0
-		 * (when called through generic_exec_single()),
-		 * so save them away before making the call:
-		 */
-		csd_flags = csd->flags;
-
 		csd->func(csd->info);

 		/*
 		 * Unlocked CSDs are valid through generic_exec_single():
 		 */
-		if (csd_flags & CSD_FLAG_LOCK)
-			csd_unlock(csd);
+		csd_unlock(csd);
 	}
 }

-- 
1.6.0.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/