linux-kernel - Re: [PATCH] truncate: drop 'oldsize' truncate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 29 Jul 2013 14:51:41 -0700
From:	Zach Brown <zab@...hat.com>
To:	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
Cc:	Al Viro <viro@...iv.linux.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Hugh Dickins <hughd@...gle.com>,
	Lukas Czerner <lczerner@...hat.com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	"Kirill A. Shutemov" <kirill@...temov.name>
Subject: Re: [PATCH] truncate: drop 'oldsize' truncate_pagecache() parameter

> @@ -50,7 +50,7 @@ static void adfs_write_failed(struct address_space *mapping, loff_t to)
>  	struct inode *inode = mapping->host;
>  
>  	if (to > inode->i_size)
> -		truncate_pagecache(inode, to, inode->i_size);
> +		truncate_pagecache(inode, inode->i_size);
>  }

All these _write_failed() boiler plate functions still technically use
'to', so I *guess* they can stay :).

> @@ -226,7 +226,7 @@ int btrfs_truncate_free_space_cache(struct btrfs_root *root,
>  
>  	oldsize = i_size_read(inode);
>  	btrfs_i_size_write(inode, 0);
> -	truncate_pagecache(inode, oldsize, 0);
> +	truncate_pagecache(inode, 0);

But after this change 'oldsize' is set but never used.  That'll generate
a warning on some versions of gcc.

Can you redo the patch with an eye to removing unused arguments and
variables further up the call stack?

- z
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/