linux-kernel - Re: regulator: pfuze100: A few small questions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 30 Jul 2013 10:36:24 +0800
From:	Robin Gong <b38343@...escale.com>
To:	Axel Lin <axel.lin@...ics.com>
CC:	Mark Brown <broonie@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: regulator: pfuze100: A few small questions

On Tue, Jul 30, 2013 at 10:26:40AM +0800, Axel Lin wrote:
> 2013/7/30 Robin Gong <b38343@...escale.com>:
> > On Mon, Jul 29, 2013 at 11:44:40PM +0800, Axel Lin wrote:
> >> >> Current code adjust min_uV and uV_step when SW2~SW4 high bit is set.
> >> >> I'm wondering if n_voltages is correct or not in this case because
> >> >> the n_voltages is calculated by original equation (max-min/step + 1).
> >> >> What is the max_uV when SW2~SW4 high bit is set?
> >> >>
> >> > If high bit set(bit6, bit0~5:vsel), min_uV/step will change from 0.4V/25mV to
> >> > 0.8V/50mV,but the n_voltages will kept the same.
> >> > For example,SW2 will vary from 0.4V to 1.975V(0x0~0x3f),if bit6 set 0(high bit)
> >> > SW2 will vary from 0.8V to 3.3V(0x40~0x72,0x72~0x7f:reversed).
> >> > Please ignore bit7 or consider it as 0.
> >>
> >> Hi Robin,
> >> According to your description:
> >> BIT6 is clear: 0.4V ~ 1.975V , step 25mV (0x0~0x3f)
> >> BIT6 is set:   0.8V ~ 3.3V, step 50mV    (0x40~0x72,0x72~0x7f:reversed)
> >>
> >> For SW2/SW3A/SW3B/SW4:
> >> I think current implementation is wrong.
> >> The supported voltage range should cover the whole range: 0.4V ~ 3.3V.
> >>
> > Hi Alex,
> Errh... It's "Axel".
> 
Sorry...And thanks for your great catch.
> > Yes,the default setting of SW2 ~SW4in the regulator array is 0.4V~1.975V
> > (Bit6 clear),and my code will check the true setting of Bit6. If Bit6=1
> > I will change min_uV from 0.4V to 0.8V ,step from 25mV to 50mV as what
> > hardware define. I don't think we should mix the two define as what you
> > mean 0.4V~3.3V. Because for every pfuze100 chip, the voltage of SW2~SW4
> > is 0.4V~1.975V or 0.8V~3.3V, not 0.4V~3.3V(from software view,Bit6 only
> > readable).
> Well, if Bit6 is read-only then current code make sense.
> 
> Regards,
> Axel
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/