lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 29 Jul 2013 17:28:49 -0700 From: Stephen Boyd <sboyd@...eaurora.org> To: Kumar Gala <galak@...eaurora.org> Cc: ohad@...ery.com, "linux-kernel@...r.kernel.org list" <linux-kernel@...r.kernel.org>, linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, Jeffrey Hugo <jhugo@...eaurora.org>, Eric Holmberg <eholmber@...eaurora.org> Subject: Re: [PATCH] hwspinlock/msm: Add support for Qualcomm MSM HW Mutex block On 07/29, Kumar Gala wrote: > > On Jul 29, 2013, at 4:40 PM, Stephen Boyd wrote: > > > On 07/29, Kumar Gala wrote: > >>> +#include <linux/of_device.h> > >>> +#include <linux/hwspinlock.h> > >>> + > >>> +#include <asm/io.h> > > > > <linux/io.h> please. > > will change, I choice <asm/io.h> since *_relaxed are arm specific. > I thought readl_relaxed() was universal for HAS_IOMEM arches. Unfortunately writel_relaxed() isn't defined on all arches. Luckily this driver depends on ARCH_MSM so it isn't a problem. Perhaps it should just depend on HAS_IOMEM so we can use it on arm64 and/or hexagon in the future without having to change the Kconfig. That would require introducing writel_relaxed() into the other arches that don't have it right now. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists