linux-kernel - RE: [PATCH] Tools: hv: check return value of system in hv_kvp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 1 Aug 2013 14:36:10 +0000
From:	KY Srinivasan <kys@...rosoft.com>
To:	Olaf Hering <olaf@...fle.de>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] Tools: hv: check return value of system in hv_kvp_daemon



> -----Original Message-----
> From: Olaf Hering [mailto:olaf@...fle.de]
> Sent: Thursday, August 01, 2013 9:04 AM
> To: KY Srinivasan; gregkh@...uxfoundation.org
> Cc: linux-kernel@...r.kernel.org; Olaf Hering
> Subject: [PATCH] Tools: hv: check return value of system in hv_kvp_daemon
> 
> hv_kvp_daemon.c: In function 'main':
> hv_kvp_daemon.c:1441:8: warning: ignoring return value of 'daemon', declared
> with attribute warn_unused_result [-Wunused-result]
> 
> Signed-off-by: Olaf Hering <olaf@...fle.de>
Signed-off-by: K. Y. Srinivasan <kys@...rosoft.com>
> ---
>  tools/hv/hv_kvp_daemon.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c
> index ba075e5..b96eccc 100644
> --- a/tools/hv/hv_kvp_daemon.c
> +++ b/tools/hv/hv_kvp_daemon.c
> @@ -1353,7 +1353,11 @@ setval_done:
>  	 */
> 
>  	snprintf(cmd, sizeof(cmd), "%s %s", "hv_set_ifconfig", if_file);
> -	system(cmd);
> +	if (system(cmd)) {
> +		syslog(LOG_ERR, "Failed to execute cmd '%s'; error: %d %s",
> +				cmd, errno, strerror(errno));
> +		return HV_E_FAIL;
> +	}
>  	return 0;
> 
>  setval_error:
> 
> 



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/