linux-kernel - Re: [PATCH] mfd: menelaus: use NULL instead of 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 2 Aug 2013 11:23:20 +0530
From:	Sachin Kamat <sachin.kamat@...aro.org>
To:	Jingoo Han <jg1.han@...sung.com>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	Lee Jones <lee.jones@...aro.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: menelaus: use NULL instead of 0

On 2 August 2013 11:20, Jingoo Han <jg1.han@...sung.com> wrote:
> 'mmc_callback_data' and 'vtg' are pointers.
> Fix the following sparse warning:
>
> drivers/mfd/menelaus.c:445:43: warning: Using plain integer as NULL pointer
> drivers/mfd/menelaus.c:469:20: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Jingoo Han <jg1.han@...sung.com>
> ---
>  drivers/mfd/menelaus.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c
> index 998ce8c..0f62ecd 100644
> --- a/drivers/mfd/menelaus.c
> +++ b/drivers/mfd/menelaus.c
> @@ -442,7 +442,7 @@ void menelaus_unregister_mmc_callback(void)
>         menelaus_remove_irq_work(MENELAUS_MMC_S2D1_IRQ);
>
>         the_menelaus->mmc_callback = NULL;
> -       the_menelaus->mmc_callback_data = 0;
> +       the_menelaus->mmc_callback_data = NULL;
>  }
>  EXPORT_SYMBOL(menelaus_unregister_mmc_callback);
>
> @@ -466,7 +466,7 @@ static int menelaus_set_voltage(const struct menelaus_vtg *vtg, int mV,
>         struct i2c_client *c = the_menelaus->client;
>
>         mutex_lock(&the_menelaus->lock);
> -       if (vtg == 0)
> +       if (vtg == NULL)

Instead you could just make this:
            if (!vtg)
>                 goto set_voltage;
>


-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/