linux-kernel - Re: [PATCH resend] drop_caches: add some documentation and info message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 2 Aug 2013 09:33:04 +0200
From:	Michal Hocko <mhocko@...e.cz>
To:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>, dave.hansen@...el.com,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>, bp@...e.de,
	Dave Hansen <dave@...ux.vnet.ibm.com>
Subject: Re: [PATCH resend] drop_caches: add some documentation and info
 message

On Thu 01-08-13 21:39:48, KOSAKI Motohiro wrote:
> On Wed, Jul 31, 2013 at 11:17 PM, Andrew Morton
> <akpm@...ux-foundation.org> wrote:
> > On Wed, 31 Jul 2013 23:11:50 -0400 KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com> wrote:
> >
> >> >> --- a/fs/drop_caches.c
> >> >> +++ b/fs/drop_caches.c
> >> >> @@ -59,6 +59,8 @@ int drop_caches_sysctl_handler(ctl_table *table, int write,
> >> >>    if (ret)
> >> >>            return ret;
> >> >>    if (write) {
> >> >> +          printk(KERN_INFO "%s (%d): dropped kernel caches: %d\n",
> >> >> +                 current->comm, task_pid_nr(current), sysctl_drop_caches);
> >> >>            if (sysctl_drop_caches & 1)
> >> >>                    iterate_supers(drop_pagecache_sb, NULL);
> >> >>            if (sysctl_drop_caches & 2)
> >> >
> >> > How about we do
> >> >
> >> >     if (!(sysctl_drop_caches & 4))
> >> >             printk(....)
> >> >
> >> > so people can turn it off if it's causing problems?
> >>
> >> The best interface depends on the purpose. If you want to detect crazy application,
> >> we can't assume an application co-operate us. So, I doubt this works.
> >
> > You missed the "!".  I'm proposing that setting the new bit 2 will
> > permit people to prevent the new printk if it is causing them problems.
> 
> No I don't. I'm sure almost all abuse users think our usage is correct. Then,
> I can imagine all crazy applications start to use this flag eventually.

I guess we do not care about those. If somebody wants to shoot his feet
then we cannot do much about it. The primary motivation was to find out
those that think this is right and they are willing to change the setup
once they know this is not the right way to do things.

I think that giving a way to suppress the warning is a good step. Log
level might be to coarse and sysctl would be an overkill.

-- 
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/