linux-kernel - Re: [PATCH] rtc: rtc-stmp3xxx: provide timeout for potentially endless loop polling a HW bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 2 Aug 2013 10:06:07 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Lothar Waßmann <LW@...O-electronics.de>
Cc:	Alessandro Zummo <a.zummo@...ertech.it>,
	rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtc: rtc-stmp3xxx: provide timeout for potentially
 endless loop polling a HW bit

On Wed, Jul 31, 2013 at 04:29:01PM +0200, Lothar Waßmann wrote:
> It's always a bad idea to poll on HW bits without a timeout.
> 
> The i.MX28 RTC can be easily brought into a state in which the RTC is
> not running (until after a power-on-reset) and thus the status bits
> which are polled in the driver won't ever change.
> 
> This patch prevents the kernel from getting stuck in this case.
> 
> Signed-off-by: Lothar Waßmann <LW@...O-electronics.de>

Acked-by: Wolfram Sang <wsa@...-dreams.de>


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)