linux-kernel - Re: [PATCHv3 1/3] video: mxsfb: fix color settings for 18bit data bus and 32bpp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 2 Aug 2013 11:35:29 +0300
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Maxime Ripard <maxime.ripard@...e-electrons.com>
CC:	<plagnioj@...osoft.com>,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	<hector.palacios@...i.com>,
	Thomas Petazzoni <thomas@...e-electrons.com>,
	<linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-fbdev@...r.kernel.org>
Subject: Re: [PATCHv3 1/3] video: mxsfb: fix color settings for 18bit data
 bus and 32bpp

On 01/08/13 11:40, Maxime Ripard wrote:
> From: Hector Palacios <hector.palacios@...i.com>
> 
> For a combination of 18bit LCD data bus width and a color
> mode of 32bpp, the driver was setting the color mapping to
> rgb666, which is wrong, as the color in memory realy has an
> rgb888 layout.
> 
> This patch also removes the setting of flag CTRL_DF24 that
> makes the driver dimiss the upper 2 bits when handling 32/24bpp
> colors in a diplay with 18bit data bus width. This flag made
> true color images display wrong in such configurations.
> 
> Finally, the color mapping rgb666 has also been removed as nobody
> is using it and high level applications like Qt5 cannot work
> with it either.
> 
> Reference: https://lkml.org/lkml/2013/5/23/220
> Signed-off-by: Hector Palacios <hector.palacios@...i.com>
> Acked-by: Juergen Beisert <jbe@...gutronix.de>
> Acked-by: Maxime Ripard <maxime.ripard@...e-electrons.com>
> Signed-off-by: Maxime Ripard <maxime.ripard@...e-electrons.com>
> ---
>  drivers/video/mxsfb.c | 26 --------------------------
>  1 file changed, 26 deletions(-)

This one is labeled as "fix". Should it got to v3.11?

 Tomi




Download attachment "signature.asc" of type "application/pgp-signature" (902 bytes)