linux-kernel - Re: [PATCH 5/5] usb: musb: dsps: use proper child nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 2 Aug 2013 20:19:27 +0530
From:	George Cherian <george.cherian@...com>
To:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
CC:	<linux-usb@...r.kernel.org>, <balbi@...com>,
	<linux-omap@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 5/5] usb: musb: dsps: use proper child nodes

On 8/2/2013 3:59 PM, Sebastian Andrzej Siewior wrote:
> On 08/01/2013 01:30 PM, Sebastian Andrzej Siewior wrote:
>> On 08/01/2013 12:52 PM, Sebastian Andrzej Siewior wrote:
>>> On 08/01/2013 07:24 AM, George Cherian wrote:
>>>>> b/arch/arm/boot/dts/am33xx.dtsi
>>>>> index 38b446b..0f756ca 100644
>>>>> --- a/arch/arm/boot/dts/am33xx.dtsi
>>>>> +++ b/arch/arm/boot/dts/am33xx.dtsi
>>>>> @@ -333,21 +337,85 @@
>>>>>                status = "disabled";
>>>>>            };
>>>>>    -        usb@...00000 {
>>>>> -            compatible = "ti,musb-am33xx";
>>>>> -            reg = <0x47400000 0x1000    /* usbss */
>>>>> -                   0x47401000 0x800        /* musb instance 0 */
>>>>> -                   0x47401800 0x800>;    /* musb instance 1 */
>>>>> -            interrupts = <17        /* usbss */
>>>>> -                      18        /* musb instance 0 */
>>>>> -                      19>;        /* musb instance 1 */
>>>>> -            multipoint = <1>;
>>>>> -            num-eps = <16>;
>>>>> -            ram-bits = <12>;
>>>>> -            port0-mode = <3>;
>>>>> -            port1-mode = <3>;
>>>>> -            power = <250>;
>>>>> +        usb: usb@...00000 {
>>>>> +            compatible = "ti,am33xx-usb";
>>>>> +            reg = <0x47400000 0x1000>;
>>>>> +            ranges;
>>>>> +            #address-cells = <1>;
>>>>> +            #size-cells = <1>;
>>>>>                ti,hwmods = "usb_otg_hs";
>>>>> +            status = "disabled";
>>>>> +
>>>>> +            ctrl_mod: control@...10000 {
>>>>> +                compatible = "ti,am335x-ctrl-module";
>>>>> +                reg = <0x44e10000 0x650>;
>>>> Do you really need to map Control Module base to 0x650? If some other
>>>> driver does this mapping
>>> This is what I cam currently not sure about. Either we minimize the
>>> register window and introduce two (the other wakeup) or we keep using
>>> the same reset driver for other devices.
>> I mean drivers/reset or something like that.
> If there are no further comments / preferences on this I'm going to
> shrink to registers and make usb only.

Yes, USB only makes sense for now.
>
> Sebastian
>


-- 
-George

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/