linux-kernel - Re: [PATCH] i2c: add sanity check to i2c_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 5 Aug 2013 11:00:30 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
Cc:	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: add sanity check to i2c_put_adapter

On Thu, Aug 01, 2013 at 02:10:46PM +0200, Sebastian Hesselbarth wrote:
> i2c_put_adapter dereferences i2c_adapter pointer passed without check
> for NULL. This adds a check for non-NULL pointer to allow i2c_put_adapter
> called with NULL and behave the same way i2c_release_client does already.

What about using WARN for the NULL case to point out the ref-counting
imbalance?

> 
> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
> ---
> Cc: Wolfram Sang <wsa@...-dreams.de>
> Cc: linux-i2c@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> ---
>  drivers/i2c/i2c-core.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
> index f32ca29..d075df6 100644
> --- a/drivers/i2c/i2c-core.c
> +++ b/drivers/i2c/i2c-core.c
> @@ -1825,7 +1825,8 @@ EXPORT_SYMBOL(i2c_get_adapter);
>  
>  void i2c_put_adapter(struct i2c_adapter *adap)
>  {
> -	module_put(adap->owner);
> +	if (adap)
> +		module_put(adap->owner);
>  }
>  EXPORT_SYMBOL(i2c_put_adapter);
>  
> -- 
> 1.7.10.4
> 

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)