linux-kernel - Re: [PATCH 1/3] mips/kvm: Improve code formatting in arch/mips/kvm/kvm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 5 Aug 2013 14:17:01 +0100
From:	James Hogan <james.hogan@...tec.com>
To:	David Daney <ddaney.cavm@...il.com>
CC:	<linux-mips@...ux-mips.org>, <ralf@...ux-mips.org>,
	<kvm@...r.kernel.org>, Sanjay Lal <sanjayl@...asys.com>,
	Gleb Natapov <gleb@...hat.com>, <linux-kernel@...r.kernel.org>,
	David Daney <david.daney@...ium.com>
Subject: Re: [PATCH 1/3] mips/kvm: Improve code formatting in arch/mips/kvm/kvm_locore.S

Hi David,

On 01/08/13 21:22, David Daney wrote:
> From: David Daney <david.daney@...ium.com>
> 
> No code changes, just reflowing some comments and consistently using
> tabs and spaces.  Object code is verified to be unchanged.
> 
> Signed-off-by: David Daney <david.daney@...ium.com>
> Acked-by: Ralf Baechle <ralf@...ux-mips.org>


> +   	 /* Put the saved pointer to vcpu (s1) back into the DDATA_LO Register */

git am detects a whitespace error here ("space before tab in indent").
It's got spaces before and after the tab actually.

>      /* load the guest context from VCPU and return */

this comment could have it's indentation fixed too

Otherwise, for all 3 patches:

Reviewed-by: James Hogan <james.hogan@...tec.com>

Thanks
James

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/