linux-kernel - Re: [PATCH] iommu/exynos: remove dead code (set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 5 Aug 2013 09:39:45 -0700
From:	Grant Grundler <grundler@...omium.org>
To:	Linux IOMMU <iommu@...ts.linux-foundation.org>,
	KyongHo Cho <pullip.cho@...sung.com>
Cc:	Joerg Roedel <joro@...tes.org>,
	Sachin Kamat <sachin.kamat@...aro.org>,
	Jiri Kosina <jkosina@...e.cz>,
	Wei Yongjun <yongjun_wei@...ndmicro.com.cn>,
	Kukjin Kim <kgene.kim@...sung.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iommu/exynos: remove dead code (set_prefbuf)

Ping?

Adding linux-iommu ML.

thanks,
grant

On Tue, Jul 2, 2013 at 9:08 AM, Grant Grundler <grundler@...omium.org> wrote:
> exynos_sysmmu_set_prefbuf() is not called any where.
>
> Signed-off-by: Grant Grundler <grundler@...omium.org>
> ---
>  drivers/iommu/exynos-iommu.c | 44 --------------------------------------------
>  1 file changed, 44 deletions(-)
>
> diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c
> index 3f32d64..0740189 100644
> --- a/drivers/iommu/exynos-iommu.c
> +++ b/drivers/iommu/exynos-iommu.c
> @@ -247,50 +247,6 @@ static void __sysmmu_set_prefbuf(void __iomem *sfrbase, unsigned long base,
>         __raw_writel(size - 1 + base,  sfrbase + REG_PB0_EADDR + idx * 8);
>  }
>
> -void exynos_sysmmu_set_prefbuf(struct device *dev,
> -                               unsigned long base0, unsigned long size0,
> -                               unsigned long base1, unsigned long size1)
> -{
> -       struct sysmmu_drvdata *data = dev_get_drvdata(dev->archdata.iommu);
> -       unsigned long flags;
> -       int i;
> -
> -       BUG_ON((base0 + size0) <= base0);
> -       BUG_ON((size1 > 0) && ((base1 + size1) <= base1));
> -
> -       read_lock_irqsave(&data->lock, flags);
> -       if (!is_sysmmu_active(data))
> -               goto finish;
> -
> -       for (i = 0; i < data->nsfrs; i++) {
> -               if ((readl(data->sfrbases[i] + REG_MMU_VERSION) >> 28) == 3) {
> -                       if (!sysmmu_block(data->sfrbases[i]))
> -                               continue;
> -
> -                       if (size1 == 0) {
> -                               if (size0 <= SZ_128K) {
> -                                       base1 = base0;
> -                                       size1 = size0;
> -                               } else {
> -                                       size1 = size0 -
> -                                               ALIGN(size0 / 2, SZ_64K);
> -                                       size0 = size0 - size1;
> -                                       base1 = base0 + size0;
> -                               }
> -                       }
> -
> -                       __sysmmu_set_prefbuf(
> -                                       data->sfrbases[i], base0, size0, 0);
> -                       __sysmmu_set_prefbuf(
> -                                       data->sfrbases[i], base1, size1, 1);
> -
> -                       sysmmu_unblock(data->sfrbases[i]);
> -               }
> -       }
> -finish:
> -       read_unlock_irqrestore(&data->lock, flags);
> -}
> -
>  static void __set_fault_handler(struct sysmmu_drvdata *data,
>                                         sysmmu_fault_handler_t handler)
>  {
> --
> 1.8.3
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/