linux-kernel - Re: [PATCH] kexec: remove unnecessary return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 06 Aug 2013 16:19:17 +0800
From:	Zhang Yanfei <zhangyanfei@...fujitsu.com>
To:	Xishi Qiu <qiuxishi@...wei.com>
CC:	ebiederm@...ssion.com, kexec@...ts.infradead.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kexec: remove unnecessary return

于 2013/8/6 16:05, Xishi Qiu 写道:
> Code can not run here forever, so remove the unnecessary return.
> 
> Signed-off-by: Xishi Qiu <qiuxishi@...wei.com>
> ---
>  kernel/kexec.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 59f7b55..c14e3ea 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -1477,8 +1477,6 @@ static int __init __parse_crashkernel(char *cmdline,
>  	else
>  		return parse_crashkernel_simple(ck_cmdline, crash_size,
>  				crash_base);
> -
> -	return 0;
>  }
>  
>  /*
> 

Hi Xishi,

change

1474         if (first_colon && (!first_space || first_colon < first_space))
1475                 return parse_crashkernel_mem(ck_cmdline, system_ram,
1476                                 crash_size, crash_base);
1477         else
1478                 return parse_crashkernel_simple(ck_cmdline, crash_size,
1479                                 crash_base);
1480 
1481         return 0;

to

1474         if (first_colon && (!first_space || first_colon < first_space))
1475                 return parse_crashkernel_mem(ck_cmdline, system_ram,
1476                                 crash_size, crash_base);

1478         return parse_crashkernel_simple(ck_cmdline, crash_size, crash_base);

seems better.
-- 
Thanks.
Zhang Yanfei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/