| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 6 Aug 2013 17:39:16 +0900 From: Simon Horman <horms@...ge.net.au> To: Xishi Qiu <qiuxishi@...wei.com> Cc: zhangyanfei@...fujitsu.com, ebiederm@...ssion.com, kexec@...ts.infradead.org, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH V2] kexec: remove unnecessary return On Tue, Aug 06, 2013 at 04:35:00PM +0800, Xishi Qiu wrote: > Code can not run here forever, so remove the unnecessary return. > > Signed-off-by: Xishi Qiu <qiuxishi@...wei.com> > Suggested-by: Zhang Yanfei <zhangyanfei@...fujitsu.com> Reviewed-by: Simon Horman <horms@...ge.net.au> > --- > kernel/kexec.c | 5 +---- > 1 files changed, 1 insertions(+), 4 deletions(-) > > diff --git a/kernel/kexec.c b/kernel/kexec.c > index 59f7b55..2a74f30 100644 > --- a/kernel/kexec.c > +++ b/kernel/kexec.c > @@ -1474,11 +1474,8 @@ static int __init __parse_crashkernel(char *cmdline, > if (first_colon && (!first_space || first_colon < first_space)) > return parse_crashkernel_mem(ck_cmdline, system_ram, > crash_size, crash_base); > - else > - return parse_crashkernel_simple(ck_cmdline, crash_size, > - crash_base); > > - return 0; > + return parse_crashkernel_simple(ck_cmdline, crash_size, crash_base); > } > > /* > -- > 1.7.1 > > > _______________________________________________ > kexec mailing list > kexec@...ts.infradead.org > http://lists.infradead.org/mailman/listinfo/kexec > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists