linux-kernel - Re: OPP: rename functions? (was [PATCH] OPP: Export opp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 06 Aug 2013 16:15:17 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Nishanth Menon <nm@...com>
Cc:	Randy Dunlap <rdunlap@...radead.org>,
	Viresh Kumar <viresh.kumar@...aro.org>, pavel@....cz,
	linaro-kernel@...ts.linaro.org, patches@...aro.org,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: OPP: rename functions? (was [PATCH] OPP: Export opp_add())

On Tuesday, August 06, 2013 08:08:20 AM Nishanth Menon wrote:
> change in subject to reflect new discussion.
> 
> On 05:53-20130806, Randy Dunlap wrote:
> > On 08/03/2013 02:25 AM, Viresh Kumar wrote:
> > >Export opp_add() so that modules can use it.
> > >
> > >Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
> > >---
> > >  drivers/base/power/opp.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > >diff --git a/drivers/base/power/opp.c b/drivers/base/power/opp.c
> > >index c8ec186..ef89897 100644
> > >--- a/drivers/base/power/opp.c
> > >+++ b/drivers/base/power/opp.c
> > >@@ -460,6 +460,7 @@ int opp_add(struct device *dev, unsigned long freq, unsigned long u_volt)
> > >  	srcu_notifier_call_chain(&dev_opp->head, OPP_EVENT_ADD, new_opp);
> > >  	return 0;
> > >  }
> > >+EXPORT_SYMBOL_GPL(opp_add);
> > 
> > Could it be renamed to pm_opp_add() or power_opp_add() ?
> > The name is a bit too unspecific IMO.
> Though this has nothing specific with this patch, an interesting point.
> 
> git grep -w opp . showed drivers/tty/n_tty.c,
> drivers/sbus/char/openprom.c and arch/powerpc/kvm/mpic.c using
> variables named opp to mean what ever they had in context. rest(around
> 40 odd files) seem to use opp as in Documentation/power/opp.txt..
> 
> We could go with a pm_ prefix or even dev_pm_opp_ prefix to be more
> specific, though I prefer just pm_. If Rafael and others are ok, I can
> post a series out.

Yup, that would be useful.  I'm for dev_pm_opp_ if that matters.

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/