linux-kernel - Re: [PATCH 10/16] fuse: Implement writepages callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 6 Aug 2013 18:25:22 +0200
From:	Miklos Szeredi <miklos@...redi.hu>
To:	Maxim Patlasov <mpatlasov@...allels.com>
Cc:	riel@...hat.com, Kirill Korotaev <dev@...allels.com>,
	Pavel Emelianov <xemul@...allels.com>,
	fuse-devel <fuse-devel@...ts.sourceforge.net>,
	Brian Foster <bfoster@...hat.com>,
	Kernel Mailing List <linux-kernel@...r.kernel.org>,
	James Bottomley <jbottomley@...allels.com>, linux-mm@...ck.org,
	Al Viro <viro@...iv.linux.org.uk>,
	Linux-Fsdevel <linux-fsdevel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	fengguang.wu@...el.com, devel@...nvz.org,
	Mel Gorman <mgorman@...e.de>
Subject: Re: [PATCH 10/16] fuse: Implement writepages callback

On Fri, Aug 2, 2013 at 5:40 PM, Maxim Patlasov <mpatlasov@...allels.com> wrote:
> 07/19/2013 08:50 PM, Miklos Szeredi пишет:
>
>> On Sat, Jun 29, 2013 at 09:45:29PM +0400, Maxim Patlasov wrote:
>>>
>>> From: Pavel Emelyanov <xemul@...nvz.org>
>>>
>>> The .writepages one is required to make each writeback request carry more
>>> than
>>> one page on it. The patch enables optimized behaviour unconditionally,
>>> i.e. mmap-ed writes will benefit from the patch even if
>>> fc->writeback_cache=0.
>>
>> I rewrote this a bit, so we won't have to do the thing in two passes,
>> which
>> makes it simpler and more robust.  Waiting for page writeback here is
>> wrong
>> anyway, see comment above fuse_page_mkwrite().  BTW we had a race there
>> because
>> fuse_page_mkwrite() didn't take the page lock.  I've also fixed that up
>> and
>> pushed a series containing these patches up to implementing ->writepages()
>> to
>>
>>    git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git
>> writepages
>>
>> Passed some trivial testing but more is needed.
>
>
> Thanks a lot for efforts. The approach you implemented looks promising, but
> it introduces the following assumption: a page cannot become dirty before we
> have a chance to wait on fuse writeback holding the page locked. This is
> already true for mmap-ed writes (due to your fixes) and it seems doable for
> cached writes as well (like we do in fuse_perform_write). But the assumption
> seems to be broken in case of direct read from local fs (e.g. ext4) to a
> memory region mmap-ed to a file on fuse fs. See how dio_bio_submit() marks
> pages dirty by bio_set_pages_dirty(). I can't see any solution for this
> use-case. Do you?

Hmm.  Direct IO on an mmaped file will do get_user_pages() which will
do the necessary page fault magic and ->page_mkwrite() will be called.
At least AFAICS.

The page cannot become dirty through a memory mapping without first
switching the pte from read-only to read-write first.  Page accounting
logic relies on this too.  The other way the page can become dirty is
through write(2) on the fs.  But we do get notified about that too.

Thanks,
Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/