linux-kernel - Re: [PATCH v2 1/2] ALSA: Added jack detection KControl support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 08 Aug 2013 07:45:05 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Mark Brown <broonie@...nel.org>
Cc:	"Felipe F. Tonello" <eu@...ipetonello.com>,
	alsa-devel@...a-project.org, Jaroslav Kysela <perex@...ex.cz>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] ALSA: Added jack detection KControl support

At Wed, 7 Aug 2013 17:45:09 +0100,
Mark Brown wrote:
> 
> On Fri, Aug 02, 2013 at 12:59:24AM -0700, Felipe F. Tonello wrote:
> 
> > +int jack_ctl_integer_info(struct snd_kcontrol *kcontrol,
> > +                          struct snd_ctl_elem_info *uinfo)
> > +{
> > +	uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER;
> > +	uinfo->count = 0x10000U;
> > +	uinfo->value.integer.min = 0;
> > +	uinfo->value.integer.max = 0xffff;
> > +	return 0;
> > +}
> 
> I'd expected to see us creating multiple boolean controls here.  I don't
> have a great problem with doing things this way but it's surprising and
> I worry about confusing existing userspace, Takashi?

Yes, multiple boolean would make more sense.


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/