linux-kernel - [PATCH] mmc: sdhci-pci : Remove logically dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri,  9 Aug 2013 23:01:46 +0300
From:	Philippe De Swert <philippe.deswert@...lamobile.com>
To:	cjb@...top.org, linux-mmc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc:	Philippe De Swert <philippe.deswert@...lamobile.com>
Subject: [PATCH] mmc: sdhci-pci : Remove logically dead code

The amount of slots is calculated as follows:
slots = PCI_SLOT_INFO_SLOTS(slots) + 1;

Which means that just after it slots cannot be 0.

Found with coverity: CID#744269

Signed-off-by: Philippe De Swert <philippe.deswert@...lamobile.com>
---
 drivers/mmc/host/sdhci-pci.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/mmc/host/sdhci-pci.c b/drivers/mmc/host/sdhci-pci.c
index d7d6bc8..9c76558 100644
--- a/drivers/mmc/host/sdhci-pci.c
+++ b/drivers/mmc/host/sdhci-pci.c
@@ -1470,9 +1470,6 @@ static int sdhci_pci_probe(struct pci_dev *pdev,
 
 	slots = PCI_SLOT_INFO_SLOTS(slots) + 1;
 	dev_dbg(&pdev->dev, "found %d slot(s)\n", slots);
-	if (slots == 0)
-		return -ENODEV;
-
 	BUG_ON(slots > MAX_SLOTS);
 
 	ret = pci_read_config_byte(pdev, PCI_SLOT_INFO, &first_bar);
-- 
1.8.1.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/