linux-kernel - Re: linux-next: manual merge of the wireless-next tree with the wireless tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 12 Aug 2013 11:15:15 -0400
From:	"John W. Linville" <linville@...driver.com>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Emmanuel Grumbach <emmanuel.grumbach@...el.com>,
	Johannes Berg <johannes.berg@...el.com>
Subject: Re: linux-next: manual merge of the wireless-next tree with the
 wireless tree

I think I have this slightly different in wireless-testing.  Johannes,
please review and advise...

John

On Mon, Aug 12, 2013 at 11:53:27AM +1000, Stephen Rothwell wrote:
> Hi John,
> 
> Today's linux-next merge of the wireless-next tree got a conflict in
> drivers/net/wireless/iwlwifi/pcie/trans.c between commit eabc4ac5d760
> ("iwlwifi: pcie: disable L1 Active after pci_enable_device") from
> thewireless tree and commit f2532b04b2ec ("iwlwifi: pcie: don't disable
> L1 for newest NICs") from the wireless-next tree.
> 
> I fixed it up (maybe - see below) and can carry the fix as necessary (no
> action is required).
> 
> -- 
> Cheers,
> Stephen Rothwell                    sfr@...b.auug.org.au
> 
> diff --cc drivers/net/wireless/iwlwifi/pcie/trans.c
> index 390e2f0,e52d1ce..0000000
> --- a/drivers/net/wireless/iwlwifi/pcie/trans.c
> +++ b/drivers/net/wireless/iwlwifi/pcie/trans.c
> @@@ -1502,16 -1400,22 +1400,22 @@@ struct iwl_trans *iwl_trans_pcie_alloc(
>   	spin_lock_init(&trans_pcie->reg_lock);
>   	init_waitqueue_head(&trans_pcie->ucode_write_waitq);
>   
>  +	if (pci_enable_device(pdev)) {
>  +		err = -ENODEV;
>  +		goto out_no_pci;
>  +	}
>  +
> - 	/* W/A - seems to solve weird behavior. We need to remove this if we
> - 	 * don't want to stay in L1 all the time. This wastes a lot of power */
> - 	pci_disable_link_state(pdev, PCIE_LINK_STATE_L0S | PCIE_LINK_STATE_L1 |
> - 			       PCIE_LINK_STATE_CLKPM);
> + 	if (!cfg->base_params->pcie_l1_allowed) {
> + 		/*
> + 		 * W/A - seems to solve weird behavior. We need to remove this
> + 		 * if we don't want to stay in L1 all the time. This wastes a
> + 		 * lot of power.
> + 		 */
> + 		pci_disable_link_state(pdev, PCIE_LINK_STATE_L0S |
> + 				       PCIE_LINK_STATE_L1 |
> + 				       PCIE_LINK_STATE_CLKPM);
> + 	}
>   
>  -	if (pci_enable_device(pdev)) {
>  -		err = -ENODEV;
>  -		goto out_no_pci;
>  -	}
>  -
>   	pci_set_master(pdev);
>   
>   	err = pci_set_dma_mask(pdev, DMA_BIT_MASK(36));



-- 
John W. Linville		Someday the world will need a hero, and you
linville@...driver.com			might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/