linux-kernel - Re: [PATCH] usb: dwc3: core: clarify usb-phy array binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 12 Aug 2013 13:05:53 -0500
From:	Felipe Balbi <balbi@...com>
To:	Kumar Gala <galak@...eaurora.org>
CC:	Mark Rutland <mark.rutland@....com>, "balbi@...com" <balbi@...com>,
	"rob.herring@...xeda.com" <rob.herring@...xeda.com>,
	Pawel Moll <Pawel.Moll@....com>,
	Stephen Warren <swarren@...dotorg.org>,
	Ian Campbell <ian.campbell@...rix.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: dwc3: core: clarify usb-phy array binding

On Fri, Aug 09, 2013 at 01:42:15PM -0500, Kumar Gala wrote:
> 
> On Aug 9, 2013, at 11:28 AM, Mark Rutland wrote:
> 
> > On Fri, Aug 09, 2013 at 04:40:32PM +0100, Kumar Gala wrote:
> >> The binding spec wasn't clear that the order of the phandles in the
> >> usb-phy array has meaning.  Clarify this point in the binding that
> >> it should be <USB2-HS-PHY, USB3-SS-PHY>.
> >> 
> >> Signed-off-by: Kumar Gala <galak@...eaurora.org>
> >> ---
> >> Documentation/devicetree/bindings/usb/dwc3.txt | 4 +++-
> >> 1 file changed, 3 insertions(+), 1 deletion(-)
> >> 
> >> diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt
> >> index 7a95c65..8a9770b 100644
> >> --- a/Documentation/devicetree/bindings/usb/dwc3.txt
> >> +++ b/Documentation/devicetree/bindings/usb/dwc3.txt
> >> @@ -6,7 +6,9 @@ Required properties:
> >>  - compatible: must be "synopsys,dwc3"
> >>  - reg : Address and length of the register set for the device
> >>  - interrupts: Interrupts used by the dwc3 controller.
> >> - - usb-phy : array of phandle for the PHY device
> >> + - usb-phy : array of phandle for the PHY device.  The first element
> >> +   in the array is expected to be a handle to the USB2/HS PHY and
> >> +   the second element is expected to be a handle to the USB3/SS PHY
> > 
> > Just to check - it's not valid to have a USB3 phy without a USB2 phy?
> 
> Don't know, hopefully Felipe will chime in on that.

that'd be a really non-standard implementation. Per-spec, USB3 is
*always* backwards compatible with USB2.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)