linux-kernel - Re: [PATCH v8 0/2] TWL6030, TWL6032 GPADC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 15 Aug 2013 10:12:16 +0100
From:	Mark Rutland <mark.rutland@....com>
To:	Oleksandr Kozaruk <oleksandr.kozaruk@...com>
Cc:	"tony@...mide.com" <tony@...mide.com>,
	"benoit.cousson@...aro.org" <benoit.cousson@...aro.org>,
	"rnayak@...com" <rnayak@...com>,
	"peter.ujfalusi@...com" <peter.ujfalusi@...com>,
	"kishon@...com" <kishon@...com>,
	"jic23@....ac.uk" <jic23@....ac.uk>,
	"grant.likely@...aro.org" <grant.likely@...aro.org>,
	"rob.herring@...xeda.com" <rob.herring@...xeda.com>,
	"lars@...afoo.de" <lars@...afoo.de>,
	"sameo@...ux.intel.com" <sameo@...ux.intel.com>,
	"ch.naveen@...sung.com" <ch.naveen@...sung.com>,
	"poeschel@...onage.de" <poeschel@...onage.de>,
	"milo.kim@...com" <milo.kim@...com>,
	"balajitk@...com" <balajitk@...com>,
	"gg@...mlogic.co.uk" <gg@...mlogic.co.uk>,
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v8 0/2] TWL6030, TWL6032 GPADC driver

Hi,

apologies for the late reply.

On Thu, Jul 25, 2013 at 02:26:51PM +0100, Oleksandr Kozaruk wrote:
> Hello,
> 
> v8 - removed unused test channels completely, removed die
>      temperature channels, as it is not known how to convert ADC code
>      to temperature. There if formula for twl6030, but no formula
>      for twl6032.
> v7 - addressed clean up comments, removed test channels
> v6 - addressed comments about trim bits, checkpatch clean up
> v5 - gpadc DT node renamed from "gpadc" to generic "adc", added
>      temperature channels; raw code is corracted with calibration
>      data.
> v4 - addressed comments: fixed style violation, bug in freeing memory,
>      added comments explaining calibration method, removed test network
>      channels from exposing to userspace, error handling for 
>      wait_for_complition
> v3 - fixed compiler warning
> v2 - the driver put in drivers/iio, and
> converted using iio facilities as suggested by Graeme.
> 
> TWL603[02] GPADC is used to measure battery voltage,
> battery temperature, battery presence ID, and could
> be used to measure twl603[02] die temperature.
> This is used on TI blaze, blaze tablet platforms.
> 
> The TWL6030/TWL6032 is a PMIC that has a GPADC with 17/19
> channels respectively. Some channels have current
> source and are used for measuring voltage drop
> on resistive load for detecting battery ID resistance,
> or measuring voltage drop on NTC resistors for external
> temperature measurements, other channels measure voltage,
> (i.e. battery voltage), and have inbuilt voltage dividers,
> thus, capable to scale voltage. Some channels are dedicated
> for measuring die temperature.
> 
> Some channels could be calibrated in 2 points, having
> offsets from ideal values in trim registers.
> 
> The difference between GPADC in TWL6030 and TWL6032:
> - 10 bit vs 12 bit ADC;
> - 17 vs 19 channels;
> - channels have different purpose(i. e. battery voltage
>   channel 8 vs channel 18);
> - trim values are interpreted differently.
> 
> The driver is derived from git://git.omapzoom.org/kernel/omap.git
> The original driver's authors and contributors are Balaji T K,
> Graeme Gregory, Ambresh K, Girish S Ghongdemath.
> 
> The changes to the original driver:
> - device tree adaptation;

I couldn't see a binding document in this series or in mainline. Have I
looked in the wrong places?

Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/