linux-kernel - usb: misc: usb3503: connect and intn mismatch in OF vs variable assignments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 16 Aug 2013 01:53:38 -0700 (PDT)
From:	Alban Browaeys <prahal@...oo.com>
To:	Dongjin Kim <tobetter@...il.com>
Cc:	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <rob.herring@...xeda.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: usb: misc: usb3503: connect and intn mismatch in OF vs variable assignments

hub->gpio_intn  = of_get_named_gpio(np, "connect-gpios", 0);
and
hub->gpio_connect = of_get_named_gpio(np, "intn-gpios", 0);

I guess they should be switched , that is connect-gpios bound to hub->gpio_connect
and intn-gpios to hub->gpio_int.

Sorry not to provides a patch. I thought that this issue might ends up with dts relying
on this broken behaviour if not pointed early ...
Either way if not fixed soon , I will have completed my branch cleanup (I also have other patches
to this file ie drivers/usb/misc/usb3503.c).

Best regards
Alban

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/