linux-kernel - [PATCH] fix for a Sparse Warning in the arch/x86/kernel/irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 19 Aug 2013 13:45:01 -0700
From:	Charvi Bhargava <cbhargava15@...uitmail.org>
To:	linux-kernel@...r.kernel.org
Subject: [PATCH] fix for a Sparse Warning in the arch/x86/kernel/irq_work.c file

I am a high school student familiarizing myself the opensource process
as well as the linux kernel. This is my first submission the LTC -
interlock mailing list.

My patch is a patch for the file arch/x86/kernel/irq_work.c in the
version linux-3.10. When I ran the kernel with Sparse, the error read:
arch/x86/kernel/irq_work.c:12:
6 warning: symbol
'arch_irq_work_interrupt' was not declared. Should it be static?

To fix this I declared the symbol for 'smp_irq_work_interrupt' in the
irq_work.h header file.

Signed off by: Charvi Bhargava <cbhargava15@...uitmail.org>

---

 include/linux/irq_work.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/irq_work.h b/include/linux/irq_work.h
index 6601702..919751a 100644
--- a/include/linux/irq_work.h
+++ b/include/linux/irq_work.h
@@ -33,6 +33,7 @@ void init_irq_work(struct irq_work *work, void
(*func)(struct irq_work *))
 void irq_work_queue(struct irq_work *work);
 void irq_work_run(void);
 void irq_work_sync(struct irq_work *work);
+void smp_irq_work_interrupt(struct pt_regs *regs);

 #ifdef CONFIG_IRQ_WORK
 bool irq_work_needs_cpu(void);
--

After creating this patch, I verified that my error did not show up
when I ran the kernel with Sparse again. I also ran the command "make
menuconfig" and changed the kernel version of the kernel so that I
could assure the correct kernel was running when I tested it, and it
was. Then I test built the kernel. It built and rebooted correctly.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/