linux-kernel - Re: [PATCH] iio: adc: Add bindigs documentation for twl6030 GPADC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 20 Aug 2013 10:12:28 +0100
From:	Mark Rutland <mark.rutland@....com>
To:	Oleksandr Kozaruk <oleksandr.kozaruk@...com>
Cc:	"grant.likely@...aro.org" <grant.likely@...aro.org>,
	"rob.herring@...xeda.com" <rob.herring@...xeda.com>,
	"rob@...dley.net" <rob@...dley.net>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Jonathan Cameron <jic23@...nel.org>,
	Guenter Roeck <linux@...ck-us.net>
Subject: Re: [PATCH] iio: adc: Add bindigs documentation for twl6030 GPADC

Hi Oleksandr,

[Adding Jonathan Cameron and Guenter Roeck to Cc]

Apologies for the delay replying to this. In attempting to verify this
made sense I went and read the IIO bindings documentation, and I'm
somewhat confused by the model.

As far as I can see, the only consumer of IIO channels is the
"iio-hwmon" binding, which seems to be a binding for Linux-specific
infrastructure rather than any actual device. This runs counter to the
way DT is supposed to function (describing the hardware rather than how
it's used). As far as I can see, this linkage is described because only
a subset of the ADCs on the device are actually wired to something?

I also see a couple of IIO bindings ("adi,adf435x*, and "adi,ad7303")
which don't describe any iio channel cells at all, so I'm somewhat
confused by what the IIO channels actually represent, and why they must
be consumed elsewhere. As far as I can see, an IIO channel represents a
single ADC's registers in an IIO device, so I'm not sure why this must
be exported via the channel concept -- it's not physically wired.

Have I misunderstood something here?

Thanks,
Mark.

On Mon, Aug 19, 2013 at 12:29:25PM +0100, Oleksandr Kozaruk wrote:
> Add required documentation for twl6030 GPADC device tree
> bindings.
> 
> Signed-off-by: Oleksandr Kozaruk <oleksandr.kozaruk@...com>
> ---
>  .../devicetree/bindings/iio/adc/twl6030-gpadc.txt  | 45 ++++++++++++++++++++++
>  1 file changed, 45 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/adc/twl6030-gpadc.txt
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/twl6030-gpadc.txt b/Documentation/devicetree/bindings/iio/adc/twl6030-gpadc.txt
> new file mode 100644
> index 0000000..6cd3ef3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/twl6030-gpadc.txt
> @@ -0,0 +1,45 @@
> +Texas Instruments twl6030/twl6032 GPADC device driver
> +
> +Required properties:
> +	- compatible: must be "ti,twl6030-gpadc" for TWL6030 or
> +	  "ti,twl6032-gpadc" for TWL6032
> +	- interrupts: interrupt number associated with it
> +	- #io-channel-cells: must be <1> - multiple IIO outputs are present
> +	  iio consumers can use following io-channels:
> +		twl6030:
> +			0 - battery type
> +			1 - battery temperature resistor value
> +			2 - audio accessory/general purpose
> +			3 - general purpose
> +			4 - temperature/general purpose
> +			5 - general purpose
> +			6 - general purpose
> +			7 - main battery
> +			8 - backup battery
> +			9 - charger input
> +			10 - VBUS
> +			11 - VBUS charging current
> +			14 - USB ID
> +		twl6032:
> +			0 - battery type
> +			1 - battery temperature resistor value
> +			2 - audio accessory/general purpose
> +			3 - temperature with external diode/general purpose
> +			4 - temperature/general purpose
> +			5 - general purpose
> +			6 - general purpose
> +			7 - system supply
> +			8 - backup battery
> +			9 - charger input
> +			10 - VBUS
> +			11 - VBUS charging current
> +			14 - USB ID
> +			17 - battery charging current
> +			18 - battery voltage
> +
> +Example:
> +	adc {
> +		compatible = "ti,twl6030-gpadc";
> +		interrupts = <3>;
> +		#io-channel-cells = <1>;
> +	};
> -- 
> 1.8.1.2
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/