lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 21 Aug 2013 10:24:58 +0800 From: Chen Gang <gang.chen@...anux.com> To: Mel Gorman <mgorman@...e.de>, kosaki.motohiro@...fujitsu.com, riel@...hat.com, hughd@...gle.com, xemul@...allels.com, rientjes@...gle.com, Wanpeng Li <liwanp@...ux.vnet.ibm.com> CC: Cyrill Gorcunov <gorcunov@...il.com>, Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: [PATCH 3/3] mm/shmem.c: check the return value of mpol_to_str() mpol_to_str() may fail, and not fill the buffer (e.g. -EINVAL), so need check about it, or buffer may not be zero based, and next seq_printf() will cause issue. Signed-off-by: Chen Gang <gang.chen@...anux.com> Cc: Cyrill Gorcunov <gorcunov@...il.com> --- mm/shmem.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/mm/shmem.c b/mm/shmem.c index e59d332..ae5112f 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -886,11 +886,14 @@ redirty: static int shmem_show_mpol(struct seq_file *seq, struct mempolicy *mpol) { char buffer[64]; + int ret; if (!mpol || mpol->mode == MPOL_DEFAULT) return 0; /* show nothing */ - mpol_to_str(buffer, sizeof(buffer), mpol); + ret = mpol_to_str(buffer, sizeof(buffer), mpol); + if (ret < 0) + return ret; seq_printf(seq, ",mpol=%s", buffer); return 0; -- 1.7.7.6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists