linux-kernel - Re: [PATCH 08/11] sched/cleanup: remove the extra parm of sched_clock_idle_wakeup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 22 Aug 2013 16:07:50 +0800
From:	Michael wang <wangyun@...ux.vnet.ibm.com>
To:	open list <linux-kernel@...r.kernel.org>
CC:	Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>, x86@...nel.org,
	linux-acpi@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>, Len Brown <lenb@...nel.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	John Stultz <john.stultz@...aro.org>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Feng Tang <feng.tang@...el.com>
Subject: Re: [PATCH 08/11] sched/cleanup: remove the extra parm of sched_clock_idle_wakeup_event()

On 08/22/2013 03:57 PM, Michael wang wrote:
> Parm 'delta_ns' has not been used, remove it to make code clean.
[snip]
>  
> -extern void sched_clock_idle_sleep_event(void);
> -extern void sched_clock_idle_wakeup_event(u64 delta_ns);

Also remove the extra declaration here.

Regards,
Michael Wang

> -
>  #ifdef CONFIG_HOTPLUG_CPU
>  extern void idle_task_exit(void);
>  #else
> diff --git a/kernel/sched/clock.c b/kernel/sched/clock.c
> index c3ae144..d111c58 100644
> --- a/kernel/sched/clock.c
> +++ b/kernel/sched/clock.c
> @@ -294,7 +294,7 @@ EXPORT_SYMBOL_GPL(sched_clock_idle_sleep_event);
>  /*
>   * We just idled delta nanoseconds (called with irqs disabled):
>   */
> -void sched_clock_idle_wakeup_event(u64 delta_ns)
> +void sched_clock_idle_wakeup_event(void)
>  {
>  	if (timekeeping_suspended)
>  		return;
> diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
> index 3612fc7..4b24d9e 100644
> --- a/kernel/time/tick-sched.c
> +++ b/kernel/time/tick-sched.c
> @@ -433,7 +433,7 @@ static void tick_nohz_stop_idle(int cpu, ktime_t now)
>  	update_ts_time_stats(cpu, ts, now, NULL);
>  	ts->idle_active = 0;
>  
> -	sched_clock_idle_wakeup_event(0);
> +	sched_clock_idle_wakeup_event();
>  }
>  
>  static ktime_t tick_nohz_start_idle(int cpu, struct tick_sched *ts)
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/