linux-kernel - Fwd: ipw2200: Fix race condition in the command completion acknowledge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 22 Aug 2013 18:00:48 +0700
From:	Stan G <stangoesagain@...il.com>
To:	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Fwd: ipw2200: Fix race condition in the command completion acknowledge

---------- Forwarded message ----------
From: Stan G <stangoesagain@...il.com>
Date: Wed, Aug 21, 2013 at 3:16 PM
Subject: ipw2200: Fix race condition in the command completion acknowledge
To: stas.yakovlev@...il.com
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org

Hi,

This is regarding kernel patch history:

>>>>

commit dd447319895d0c0af423e483d9b63f84f3f8869a
Author: Stanislav Yakovlev <stas.yakovlev@...il.com>
Date: Thu Apr 19 15:55:09 2012 -0400
ipw2200: Fix race condition in the command completion acknowledge

Driver incorrectly validates command completion: instead of waiting
for a command to be acknowledged it continues execution. Most of the
time driver gets acknowledge of the command completion in a tasklet
before it executes the next one. But sometimes it sends the next
command before it gets acknowledge for the previous one. In such a
case one of the following error messages appear in the log:

Failed to send SYSTEM_CONFIG: Already sending a command.
Failed to send ASSOCIATE: Already sending a command.
Failed to send TX_POWER: Already sending a command.

After that you need to reload the driver to get it working again.

This bug occurs during roaming (reported by Sam Varshavchik)
https://bugzilla.redhat.com/show_bug.cgi?id=738508
and machine booting (reported by Tom Gundersen and Mads Kiilerich)
https://bugs.archlinux.org/task/28097
https://bugzilla.redhat.com/show_bug.cgi?id=802106

This patch doesn't fix the delay issue during firmware load.
But at least device now works as usual after boot.

Cc: stable@...nel.org
Signed-off-by: Stanislav Yakovlev <stas.yakovlev@...il.com>
Signed-off-by: John W. Linville <linville@...driver.com>

>>>>

I am having intermittent problems with dropping wifi network while the
 AP is still visible and dmesg produces this:

      [26617.864791] ipw2200: Failed to send ASSOCIATE: Already
sending a command.

I'm on OpenSuse 12.3 with 3.7.10-1.16

The whole story of this problem can be viewed here:

https://forums.opensuse.org/english/get-technical-help-here/network-internet/489371-wifi-up-access-point-visible-but-network-goes-down.html

where at the end I was advised to contact you, guys.

Reloading driver restores network as expected.

Can anything be done regarding this issue or is the driver too old to be fixed?

Would updating to the latest kernel solve the problem?

Stan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/