linux-kernel - Re: [PATCH 4/4] staging: ozwpan: Create deferred work to destroy PD object.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 22 Aug 2013 21:45:55 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Rupesh Gujare <rupesh.gujare@...el.com>
CC:	devel@...uxdriverproject.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org
Subject: Re: [PATCH 4/4] staging: ozwpan: Create deferred work to destroy
 PD object.

Hello.

On 08/22/2013 08:38 PM, Rupesh Gujare wrote:

> Currently we call oz_pd_destroy() from softirq context, where we
> try to destroy relevant data structures, as well we kill a tasklet
> which always result in following kernel warning.

> [12279.262194] Attempt to kill tasklet from interrupt
> [12279.262202] Attempt to kill tasklet from interrupt

> This patch defers deallocation of data structures to work queue.

> Signed-off-by: Rupesh Gujare <rupesh.gujare@...el.com>
> ---
>   drivers/staging/ozwpan/ozpd.c |   28 +++++++++++++++++++++++-----
>   drivers/staging/ozwpan/ozpd.h |    1 +
>   2 files changed, 24 insertions(+), 5 deletions(-)

> diff --git a/drivers/staging/ozwpan/ozpd.c b/drivers/staging/ozwpan/ozpd.c
> index 2514d79..06004c8 100644
> --- a/drivers/staging/ozwpan/ozpd.c
> +++ b/drivers/staging/ozwpan/ozpd.c
[...]
> @@ -259,6 +257,26 @@ void oz_pd_destroy(struct oz_pd *pd)
>   }
>
>   /*------------------------------------------------------------------------------
> + * Context: softirq or Process
> + */
> +void oz_pd_destroy(struct oz_pd *pd)
> +{
> +	int ret;
> +
> +	if (hrtimer_active(&pd->timeout))
> +		hrtimer_cancel(&pd->timeout);
> +	if (hrtimer_active(&pd->heartbeat))
> +		hrtimer_cancel(&pd->heartbeat);
> +
> +	memset(&pd->workitem, 0, sizeof(pd->workitem));
> +	INIT_WORK(&pd->workitem, oz_pd_free);

    Hm, memset(), then INIT_WORK()? Is memset() necessary?

> +	ret = schedule_work(&pd->workitem);
> +

    Don't think empty line is needed here.

> +	if (ret)
> +		oz_pd_dbg(pd, ON, "failed to schedule workitem\n");
> +}
> +
> +/*------------------------------------------------------------------------------
>    * Context: softirq-serialized
>    */
>   int oz_services_start(struct oz_pd *pd, u16 apps, int resume)
> diff --git a/drivers/staging/ozwpan/ozpd.h b/drivers/staging/ozwpan/ozpd.h
> index 996ef65..12c7129 100644
> --- a/drivers/staging/ozwpan/ozpd.h
> +++ b/drivers/staging/ozwpan/ozpd.h
> @@ -99,6 +99,7 @@ struct oz_pd {
>   	u8      timeout_type;
>   	struct tasklet_struct   heartbeat_tasklet;
>   	struct tasklet_struct   timeout_tasklet;
> +	struct work_struct workitem;

    Er, other field names seem aligned, what about this one?

>   };

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/