linux-kernel - Re: [PATCH] imx-drm: Fix probe failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 28 Aug 2013 11:39:11 -0300
From:	Fabio Estevam <festevam@...il.com>
To:	Sascha Hauer <s.hauer@...gutronix.de>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Shawn Guo <shawn.guo@...aro.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Fabio Estevam <fabio.estevam@...escale.com>
Subject: Re: [PATCH] imx-drm: Fix probe failure

On Wed, Aug 28, 2013 at 2:27 AM, Sascha Hauer <s.hauer@...gutronix.de> wrote:

> Nack. We need the references to prevent that encoders/connectors are
> (de)registered while the device is active. Simply dropping this code is
> no solution.

Any suggestions about a proper way of handling this?

After b5dc0d10, imx_drm_device_get() is called from
imx_drm_driver_load(), which increments the 'references' very early
now.

Then when we check:

    if (imxdrm->references) {
        ret = -EBUSY;
        goto err_busy;
    }

,it will fail always.

Not sure where is a proper location to increment/decrement
'imxdrm->references' though.

Tried to look at other drm drivers, but could not find examples on how
to deal with such references.

Regards,

Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/