linux-kernel - Re: FTRACE_WARN_ON((rec->flags & ~FTRACE_FL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 28 Aug 2013 14:27:10 -0400
From:	Dave Jones <davej@...hat.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: FTRACE_WARN_ON((rec->flags & ~FTRACE_FL_MASK) == 0))

On Wed, Aug 28, 2013 at 11:17:46AM -0400, Steven Rostedt wrote:
 
 > Dave, can you add this patch to your kernels you test, and that way,
 > the next time you hit this error, I want to see if this warning was
 > triggered too.
 > 
 > If we did not unregister the ftrace ops but free the filters, it will
 > cause the accounting to get out of whack.
 > 
 > Thanks!
 > 
 > -- Steve
 > 
 > diff --git a/kernel/trace/trace_event_perf.c b/kernel/trace/trace_event_perf.c
 > index 80c36bc..05167bb 100644
 > --- a/kernel/trace/trace_event_perf.c
 > +++ b/kernel/trace/trace_event_perf.c
 > @@ -306,6 +306,7 @@ static int perf_ftrace_function_unregister(struct perf_event *event)
 >  {
 >  	struct ftrace_ops *ops = &event->ftrace_ops;
 >  	int ret = unregister_ftrace_function(ops);
 > +	WARN_ON(ret);
 >  	ftrace_free_filter(ops);
 >  	return ret;
 >  }

I hit the WARN in the subject, and then this new one immediately afterwards.

	Dave.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/