linux-kernel - Re: [PATCH] HID: roccat: Added support for KonePureOptical

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 29 Aug 2013 22:41:36 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Stefan Achatz <erazor_de@...rs.sourceforge.net>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: roccat: Added support for KonePureOptical

On Thu, 29 Aug 2013, Stefan Achatz wrote:

> KonePureOptical is a KonePure with different sensor.
> 
> Signed-off-by: Stefan Achatz <erazor_de@...rs.sourceforge.net>
> ---
>  drivers/hid/hid-ids.h             |    1 +
>  drivers/hid/hid-roccat-konepure.c |    3 ++-
>  2 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index ffe4c7a..ef18cd9 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -716,6 +716,7 @@
>  #define USB_DEVICE_ID_ROCCAT_KONE	0x2ced
>  #define USB_DEVICE_ID_ROCCAT_KONEPLUS	0x2d51
>  #define USB_DEVICE_ID_ROCCAT_KONEPURE	0x2dbe
> +#define USB_DEVICE_ID_ROCCAT_KONEPURE_OPTICAL	0x2db4
>  #define USB_DEVICE_ID_ROCCAT_KONEXTD	0x2e22
>  #define USB_DEVICE_ID_ROCCAT_KOVAPLUS	0x2d50
>  #define USB_DEVICE_ID_ROCCAT_LUA	0x2c2e
> diff --git a/drivers/hid/hid-roccat-konepure.c b/drivers/hid/hid-roccat-konepure.c
> index c79d0b0..5850959 100644
> --- a/drivers/hid/hid-roccat-konepure.c
> +++ b/drivers/hid/hid-roccat-konepure.c
> @@ -262,6 +262,7 @@ static int konepure_raw_event(struct hid_device *hdev,
>  
>  static const struct hid_device_id konepure_devices[] = {
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_ROCCAT, USB_DEVICE_ID_ROCCAT_KONEPURE) },
> +	{ HID_USB_DEVICE(USB_VENDOR_ID_ROCCAT, USB_DEVICE_ID_ROCCAT_KONEPURE_OPTICAL) },
>  	{ }
>  };

I believe you are missing hid_have_special_driver[] entry.

>  
> @@ -300,5 +301,5 @@ module_init(konepure_init);
>  module_exit(konepure_exit);
>  
>  MODULE_AUTHOR("Stefan Achatz");
> -MODULE_DESCRIPTION("USB Roccat KonePure driver");
> +MODULE_DESCRIPTION("USB Roccat KonePure/Optical driver");
>  MODULE_LICENSE("GPL v2");
> -- 
> 1.7.3.4
> 
> 
> 

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/