linux-kernel - Re: On the correctness of dbe3ed1c078c193be34326728d494c5c4bc115e2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 1 Sep 2013 09:12:44 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Randy Dunlap <rdunlap@...otime.net>,
	Ingo Molnar <mingo@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Arjan van de Ven <arjan@...ux.intel.com>
Subject: Re: On the correctness of dbe3ed1c078c193be34326728d494c5c4bc115e2

On Sun, Sep 1, 2013 at 9:00 AM, H. Peter Anvin <hpa@...or.com> wrote:
> On 09/01/2013 08:58 AM, Linus Torvalds wrote:
>>
>> Not necessarily. Don't we basically do exactly that for the F00F bug
>> workaround, for example?
>
> We do, but only after matching on an exact address (is_f00f_bug()).
> Note also that is_f00f_bug() isn't conditional on PF_USER.

Right. But I'm wondering why you care? There's nothing we can do about
spurious page faults if they dp happen. The PF_USER thing we do means
that bad_area_nosemaphore will go through the "send signal" path.

I guess we can remove the setting of PF_USER, but that would just mean
that then we have to test for "is_user_vm()" in bad_area_semaphore
instead. So the end result would be exactly the same.

And my point was that we actually do have this "users can cause page
faults on IDT etc accesses" as a real thing.

So basically: what do you propose to do? You basically can't remove
the line without adding it somewhere else.

                  Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/