linux-kernel - Re: [PATCH 0/8] ceph: fscache support & upstream changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 06 Sep 2013 16:59:02 +0100
From:	David Howells <dhowells@...hat.com>
To:	Milosz Tanski <milosz@...in.com>
Cc:	dhowells@...hat.com, Sage Weil <sage@...tank.com>,
	sprabhu@...hat.com, ceph-devel <ceph-devel@...r.kernel.org>,
	"Yan, Zheng" <zheng.z.yan@...el.com>,
	Hongyi Jia <jiayisuse@...il.com>,
	"linux-cachefs@...hat.com" <linux-cachefs@...hat.com>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/8] ceph: fscache support & upstream changes

Milosz Tanski <milosz@...in.com> wrote:

> After running this for a day on some loaded machines I ran into what
> looks like an old issue with the new code. I remember you saw an issue
> that manifested it self in a similar way a while back.
> 
> [13837253.462779] FS-Cache: Assertion failed
> [13837253.462782] 3 == 5 is false
> [13837253.462807] ------------[ cut here ]------------
> [13837253.462811] kernel BUG at fs/fscache/operation.c:414!

Bah.

I forgot to call fscache_op_complete().  Patch updated and repushed.

Btw, I've reordered the patches to put the CIFS patch last.  Can you merge the
patches prior to the CIFS commit from my branch rather than cherry picking
them so that if they go via two different routes, GIT will handle the merge
correctly?  I've stuck a tag on it (fscache-fixes-for-ceph) to make that
easier for you.

I've also asked another RH engineer to try doing some basic testing on the
CIFS stuff - which may validate the fscache_readpages_cancel patch.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/