[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 9 Sep 2013 15:08:51 +0900
From: Yasuaki Ishimatsu <isimatu.yasuaki@...fujitsu.com>
To: Xishi Qiu <qiuxishi@...wei.com>
CC: Andrew Morton <akpm@...ux-foundation.org>,
Wen Congyang <wency@...fujitsu.com>,
Tang Chen <tangchen@...fujitsu.com>,
Toshi Kani <toshi.kani@...com>, <linux-mm@...ck.org>,
LKML <linux-kernel@...r.kernel.org>, <kosaki.motohiro@...il.com>
Subject: Re: [PATCH 1/2] mm/hotplug: rename the function is_memblock_offlined_cb()
[CCing Kosaki since he maintains mm/memory_hotplug.c]
(2013/09/09 12:27), Xishi Qiu wrote:
> Function is_memblock_offlined() return 1 means memory block is offlined,
> but is_memblock_offlined_cb() return 1 means memory block is not offlined,
> this will confuse somebody, so rename the function.
>
> Signed-off-by: Xishi Qiu <qiuxishi@...wei.com>
> Acked-by: Yasuaki Ishimatsu <isimatu.yasuaki@...fujitsu.com>
> ---
I have not acked your previous patch yet. But this patch seems good to me.
So I acked the patch.
Thanks,
Yasuaki Ishimatsu
> mm/memory_hotplug.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index ca1dd3a..85f80b7 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -1657,7 +1657,7 @@ int walk_memory_range(unsigned long start_pfn, unsigned long end_pfn,
> }
>
> #ifdef CONFIG_MEMORY_HOTREMOVE
> -static int is_memblock_offlined_cb(struct memory_block *mem, void *arg)
> +static int check_memblock_offlined_cb(struct memory_block *mem, void *arg)
> {
> int ret = !is_memblock_offlined(mem);
>
> @@ -1794,7 +1794,7 @@ void __ref remove_memory(int nid, u64 start, u64 size)
> * if this is not the case.
> */
> ret = walk_memory_range(PFN_DOWN(start), PFN_UP(start + size - 1), NULL,
> - is_memblock_offlined_cb);
> + check_memblock_offlined_cb);
> if (ret) {
> unlock_memory_hotplug();
> BUG();
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists