linux-kernel - Oddness in security/Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 09 Sep 2013 11:41:21 -0400
From:	Valdis Kletnieks <Valdis.Kletnieks@...edu>
To:	Linus Torvalds <torvalds@...ux-foundation.org>,
	James Morris <james.l.morris@...cle.com>,
	Stephen Smalley <sds@...ho.nsa.gov>,
	Eric Paris <eparis@...isplace.org>
Cc:	linux-kernel@...r.kernel.org, linux-security-module@...r.kernel.org
Subject: Oddness in security/Makefile

Seen in security/Makefile:

% git blame security/Makefile
...
^1da177e (Linus Torvalds  2005-04-16 15:20:36 -0700 15)
^1da177e (Linus Torvalds  2005-04-16 15:20:36 -0700 16) # Object file lists
da31894e (Eric Paris      2008-08-22 11:35:57 -0400 17) obj-$(CONFIG_SECURITY)                  += security.o capability.o
da31894e (Eric Paris      2008-08-22 11:35:57 -0400 18) obj-$(CONFIG_SECURITYFS)                += inode.o
^1da177e (Linus Torvalds  2005-04-16 15:20:36 -0700 19) # Must precede capability.o in order to stack properly.
^1da177e (Linus Torvalds  2005-04-16 15:20:36 -0700 20) obj-$(CONFIG_SECURITY_SELINUX)          += selinux/built-in.o
5915eb53 (Miklos Szeredi  2008-07-03 20:56:05 +0200 21) obj-$(CONFIG_SECURITY_SMACK)            += smack/built-in.o
...

What's wrong with this picture? Line 19 looks more than slightly confused,
and it has been for several years....

Content of type "application/pgp-signature" skipped