linux-kernel - [PATCH 2/5] USB : serial : get protected tty in handle_dcd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon,  9 Sep 2013 18:01:17 +0200
From:	Paul Chavent <Paul.Chavent@...ra.fr>
To:	linux-usb@...r.kernel.org, gregkh@...uxfoundation.org,
	jhovold@...il.com, fschaefer.oss@...glemail.com, jslaby@...e.cz,
	max@...e.de, giometti@...eenne.com
Cc:	linux-kernel@...r.kernel.org, Paul Chavent <Paul.Chavent@...ra.fr>
Subject: [PATCH 2/5] USB : serial : get protected tty in handle_dcd_change.

This patch depends on 72df17e... (PATCH 1). It restores the retreiving
of a protected instance of tty.  As opposed to the serialcore.c
dcd_change implementation, the callers of dcd_change used to
get protected tty instance.

Signed-off-by: Paul Chavent <paul.chavent@...ra.fr>
---
 drivers/usb/serial/generic.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/serial/generic.c b/drivers/usb/serial/generic.c
index 33f1df1..91f0592 100644
--- a/drivers/usb/serial/generic.c
+++ b/drivers/usb/serial/generic.c
@@ -566,7 +566,7 @@ void usb_serial_handle_dcd_change(struct usb_serial_port *usb_port,
 				unsigned int status)
 {
 	struct tty_port *port = &usb_port->port;
-	struct tty_struct *tty = port->tty;
+	struct tty_struct *tty = tty_port_tty_get(port);
 
 	dev_dbg(&usb_port->dev, "%s - status %d\n", __func__, status);
 
@@ -574,6 +574,8 @@ void usb_serial_handle_dcd_change(struct usb_serial_port *usb_port,
 		wake_up_interruptible(&port->open_wait);
 	else if (tty && !C_CLOCAL(tty))
 		tty_hangup(tty);
+
+	tty_kref_put(tty);
 }
 EXPORT_SYMBOL_GPL(usb_serial_handle_dcd_change);
 
-- 
1.7.12.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/