linux-kernel - Re: [PATCH] Staging: rtl8188eu: checkpatch.pl warnings removed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 09 Sep 2013 11:10:18 -0500
From:	Larry Finger <Larry.Finger@...inger.net>
To:	farisdehaan@...il.com
CC:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: rtl8188eu: checkpatch.pl warnings removed

On 09/09/2013 10:34 AM, farisdehaan@...il.com wrote:
> From: Faris de Haan <farisdehaan@...il.com>
>
> Fixed some of the coding style issues reported by checkpatch.pl
>
> Signed-off-by: Faris de Haan <farisdehaan@...il.com>
> ---
>   drivers/staging/rtl8188eu/core/rtw_sta_mgt.c |    7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> index c2977be..cd3c9a7 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> @@ -267,9 +267,8 @@ _func_enter_;
>
>   		rtw_mfree_sta_priv_lock(pstapriv);
>
> -		if (pstapriv->pallocated_stainfo_buf) {
> +		if (pstapriv->pallocated_stainfo_buf)
>   			rtw_vmfree(pstapriv->pallocated_stainfo_buf, sizeof(struct sta_info)*NUM_STA+4);
> -		}
>   	}
>
>   _func_exit_;
> @@ -315,7 +314,7 @@ _func_enter_;
>
>   		rtw_list_insert_tail(&psta->hash_list, phash_list);
>
> -		pstapriv->asoc_sta_count++ ;
> +		pstapriv->asoc_sta_count++;
>
>   		_exit_critical_bh(&(pstapriv->sta_hash_lock), &irql2);
>
> @@ -419,7 +418,7 @@ _func_enter_;
>   	_cancel_timer_ex(&psta->addba_retry_timer);
>
>   	/* for A-MPDU Rx reordering buffer control, cancel reordering_ctrl_timer */
> -	for (i = 0; i < 16 ; i++) {
> +	for (i = 0; i < 16; i++) {
>   		unsigned long irql;
>   		struct list_head *phead, *plist;
>   		union recv_frame *prframe;
>

Acked-by: Larry Finger <Larry.Finger@...inger.net>

Thanks,

Larry

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/