linux-kernel - Re: [PATCH] rcu: Is it safe to enter an RCU read-side critical section?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 9 Sep 2013 18:11:30 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Christoph Lameter <cl@...ux.com>,
	Peter Zijlstra <peterz@...radead.org>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Eric Dumazet <eric.dumazet@...il.com>,
	linux-kernel@...r.kernel.org, mingo@...e.hu, laijs@...fujitsu.com,
	dipankar@...ibm.com, akpm@...ux-foundation.org,
	mathieu.desnoyers@...icios.com, josh@...htriplett.org,
	niv@...ibm.com, tglx@...utronix.de, dhowells@...hat.com,
	edumazet@...gle.com, darren@...art.com, sbw@....edu
Subject: Re: [PATCH] rcu: Is it safe to enter an RCU read-side critical
 section?

* Steven Rostedt <rostedt@...dmis.org> wrote:

> On Mon, 9 Sep 2013 18:00:24 +0200
> Ingo Molnar <mingo@...nel.org> wrote:
> 
> > So my NAK stands: you are still in denial, you should stop the silly 
> > arguing and you should stop wasting maintainer time. You need to 
> > address PeterZ's review feedback and fix the bugs in your patches, 
> > ASAP.
> 
> To Christoph's credit. He did post patches with debug checks. We just 
> need to get around to review them.

I saw those, he posted 'needs testing' patches. He still behaved 
passive-aggressively, pretending that it was some difficult task to 
perform, as if we were pulling his teeth.

And in this thread he still arguing nonsense in the middle in the merge 
window, claiming that CONFIG_PREEMPT=y is 'academic' - when just a cursory 
look at lkml or just about anywhere else would tell him that amongst bug 
reporters on lkml it's as popular as the other preempt options.

Adding and keeping preempt checks is not rocket science.

The thing is, we should not be forced to shout at him at all: Christoph's 
should be _proactive_ in addressing the shortcomings that were readily 
pointed out literally years ago during review in a friendly fashion, 
instead of wasting a lot of people's time trying to argue around it...

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/