linux-kernel - Re: [052/121] cifs: extend the buffer length enought for sprintf() using

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 8 Sep 2013 23:03:53 -0400
From:	Scott Lovenberg <scott.lovenberg@...il.com>
To:	Ben Hutchings <ben@...adent.org.uk>
Cc:	LKML <linux-kernel@...r.kernel.org>, stable@...r.kernel.org,
	akpm@...ux-foundation.org, Jeff Layton <jlayton@...hat.com>,
	Chen Gang <gang.chen@...anux.com>,
	Shirish Pargaonkar <shirishpargaonkar@...il.com>,
	Steve French <smfrench@...il.com>
Subject: Re: [052/121] cifs: extend the buffer length enought for sprintf() using

On Sat, Sep 7, 2013 at 10:52 PM, Ben Hutchings <ben@...adent.org.uk> wrote:
>
> 3.2.51-rc1 review patch.  If anyone has any objections, please let me know.
>
> ------------------
>
> From: Chen Gang <gang.chen@...anux.com>
>
> commit 057d6332b24a4497c55a761c83c823eed9e3f23b upstream.
>
> For cifs_set_cifscreds() in "fs/cifs/connect.c", 'desc' buffer length
> is 'CIFSCREDS_DESC_SIZE' (56 is less than 256), and 'ses->domainName'
> length may be "255 + '\0'".
>
> The related sprintf() may cause memory overflow, so need extend related
> buffer enough to hold all things.
>
> It is also necessary to be sure of 'ses->domainName' must be less than
> 256, and define the related macro instead of hard code number '256'.
>
> Signed-off-by: Chen Gang <gang.chen@...anux.com>
> Reviewed-by: Jeff Layton <jlayton@...hat.com>
> Reviewed-by: Shirish Pargaonkar <shirishpargaonkar@...il.com>
> Reviewed-by: Scott Lovenberg <scott.lovenberg@...il.com>
> Signed-off-by: Steve French <smfrench@...il.com>
> [bwh: Backported to 3.2:
>  - Adjust context in sess.c
>  - Drop inapplicable changes to connect.c]
> Signed-off-by: Ben Hutchings <ben@...adent.org.uk>


Looks good to me.

-- 
Peace and Blessings,
-Scott.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/