linux-kernel - Re: [PATCH 1/5] iio: adc: remove unnecessary work pending test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 09 Sep 2013 22:14:47 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	michael.hennerich@...log.com
CC:	Tejun Heo <tj@...nel.org>, Xie XiuQi <xiexiuqi@...wei.com>,
	Jonathan Cameron <jic23@....ac.uk>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Dmitry Torokhov <dtor@...l.ru>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andres Salomon <dilinger@...ued.net>,
	Chris Ball <cjb@...top.org>,
	Jon Nettleton <jon.nettleton@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Nadia Derbey <Nadia.Derbey@...l.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Li Bin <huawei.libin@...wei.com>,
	Lars-Peter Clausen <lars@...afoo.de>
Subject: Re: [PATCH 1/5] iio: adc: remove unnecessary work pending test

On 09/09/13 16:23, Michael Hennerich wrote:
> On 09/07/2013 10:44 PM, Jonathan Cameron wrote:
>> ccing Michael Hennerich and Lars-Peter Clausen,
> 
> Looks good to me!
> 
> /Acked-by/: /Michael Hennerich/ <michael.hennerich@...log.com>
Applied to the togreg branch of iio.git.

Thanks
> 
>>
>> On 09/06/13 16:20, Tejun Heo wrote:
>>> On Fri, Sep 06, 2013 at 07:02:34PM +0800, Xie XiuQi wrote:
>>>> Remove unnecessary work pending test before calling schedule_work().
>>>> It has been tested in queue_work_on() already. No functional changed.
>>>>
>>>> Signed-off-by: Xie XiuQi <xiexiuqi@...wei.com>
>>>> Cc: Tejun Heo <tj@...nel.org>
>>> Reviewed-by: Tejun Heo <tj@...nel.org>
>>>
>>> One nit below tho.
>>>
>>>> -	if (iio_buffer_enabled(indio_dev)) {
>>>> -		if (!work_pending(&st->poll_work))
>>>> -			schedule_work(&st->poll_work);
>>>> -	} else {
>>>> +	if (iio_buffer_enabled(indio_dev))
>>>> +		schedule_work(&st->poll_work);
>>>> +	else {
>>>>  		st->done = true;
>>>>  		wake_up_interruptible(&st->wq_data_avail);
>>>>  	}
>>> Please don't drop the parentheses.  The convention is to have either
>>> both or none on if/else.
>> I'll fix this up on applying if everyone is happy (can't see why the
>> won't be, but best to check!) Michael is clearly given as the author of driver
>> so should probably have been in the cc list. Whilst I might apply this directly
>> as maintainer I much prefer if I get an ack from the driver author as if nothing
>> else it gives me a warm fuzzy feeling ;)
>>
>> Also patch title should mention that a) this is a staging driver, b) which adc driver it
>> applies to. I'll fix that up as well on applying it.
>>
>> Thanks for the patch though, it would probably never have been noticed otherwise!
>>
>>> Thanks.
>>>
> 
> 
> -- 
> Greetings,
> Michael
> 
> --
> Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
> Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
> Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin,
> Margaret Seif
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/