linux-kernel - Re: [PATCH v3 2/2] Documentation: dt: hwmon: add OF document for LM90

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 09 Sep 2013 16:14:44 -0600
From:	Stephen Warren <swarren@...dotorg.org>
To:	Guenter Roeck <linux@...ck-us.net>
CC:	Wei Ni <wni@...dia.com>, khali@...ux-fr.org, broonie@...nel.org,
	lm-sensors@...sensors.org, linux-tegra@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] Documentation: dt: hwmon: add OF document for
 LM90

On 09/09/2013 04:52 AM, Guenter Roeck wrote:
> On 09/09/2013 03:29 AM, Wei Ni wrote:
>> Add OF document for LM90 in Documentation/devicetree/.

>> diff --git a/Documentation/devicetree/bindings/hwmon/lm90.txt

>> +* LM90 series thermometer.
>> +
>> +Required node properties:
>> +- compatible: manufacture and chip name, one of
> 
> manufacturer
> 
>> +        "<manufacture>,adm1032"
...
>> +        "<manufacture>,sa56004"
>
> Shouldn't the manufacturers be listed explicitly ?

Yes, and they must all be present in
Documentation/devicetree/bindings/vendor-prefixes.txt.

>> +Example LM90 node:
>> +
>> +temp-sensor {
>> +    compatible = "onnn,nct1008";
>> +    reg = <0x4c>;
>> +    vcc-supply = <&palmas_ldo6_reg>;
>> +    interrupt-parent = <&gpio>;
> 
> List above as optional property.

I believe it's common not to document this, since it's implicitly
supported as part of any node that is an interrupt source.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/