linux-kernel - Re: Resend: [PATCH 2/2] s390: provide hardware randomness from zcrypt card to /dev/random

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 10 Sep 2013 17:39:34 -0700
From:	Joe Perches <joe@...ches.com>
To:	Torsten Duwe <duwe@....de>
Cc:	tytso@....edu, ingo.tuchscherer@...ibm.com,
	linux-kernel@...r.kernel.org,
	Hans-Georg Markgraf <MGRF@...ibm.com>,
	Gerald Schaefer <GERALDSC@...ibm.com>,
	Martin Schwidefsky <martin.schwidefsky@...ibm.com>
Subject: Re: Resend: [PATCH 2/2] s390: provide hardware randomness from
 zcrypt card to /dev/random

On Wed, 2013-09-04 at 10:48 +0200, Torsten Duwe wrote:
[]
> +++ b/drivers/s390/crypto/zcrypt_api.c

> @@ -1141,6 +1144,36 @@ static struct hwrng zcrypt_rng_dev = {
][
> +static int zcrypt_hwrng_fillfn(void *unused)
> +{
> +       long rc;
> +
> +       while (!kthread_should_stop()) {
> +               rc = zcrypt_rng((char *)zcrypt_rng_buffer);
> +               if (rc == -ENODEV || rc == -EINVAL || rc == -ENOMEM) {
> +                       pr_err("zcrypt_rng unavailable: %ld", rc);

please add terminating newlines

			pr_err("zcrypt_rng unavailable: %ld\n", rc);

etc...



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/