linux-kernel - Re: [PATCH] workqueue: remove redundant timer_stats_timer_set_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 11 Sep 2013 08:49:34 +0800
From:	Libin <huawei.libin@...wei.com>
To:	Tejun Heo <tj@...nel.org>
CC:	<tglx@...utronix.de>, <linux-kernel@...r.kernel.org>,
	<akpm@...ux-foundation.org>, <mingo@...hat.com>,
	<wangyijing@...wei.com>, <guohanjun@...wei.com>
Subject: Re: [PATCH] workqueue: remove redundant timer_stats_timer_set_start_info()
 call

On 2013/9/10 21:45, Tejun Heo wrote:
> On Tue, Sep 10, 2013 at 02:35:27PM +0800, Libin wrote:
>> From: Li Bin <huawei.libin@...wei.com>
>>
>> There is a redundant call for timer_stats_timer_set_start_info(),
>> because it is the responsibility of the 'timer add' function:
>>
>> add_timer_on()
>> |- timer_stats_timer_set_start_info()
>>
>> add_timer()
>> |- mod_timer()
>> 	|- __mod_timer()
>> 		|- timer_stats_timer_set_start_info()
>>
>> So the calling here is redundant, remove it.
> 
> I think it's intentional to record the caller's address so that timers
> from delayed_work items can be distinguished.
> 

Indeed the case, thank you tejun.
Libin

> Thanks.
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/