linux-kernel - Re: [PATCH 2/10] xtensa: Cocci spatch "noderef"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 19 Sep 2013 15:10:22 -0700
From:	Joe Perches <joe@...ches.com>
To:	Thomas Meyer <thomas@...3r.de>
Cc:	chris@...kel.net, jcmvbkbc@...il.com,
	linux-xtensa@...ux-xtensa.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/10] xtensa: Cocci spatch "noderef"

On Thu, 2013-09-19 at 23:42 +0200, Thomas Meyer wrote:
> sizeof when applied to a pointer typed expression gives the size of the
> pointer.

Hi Thomas, thanks for doing the series...

> diff -u -p a/arch/xtensa/platforms/iss/network.c b/arch/xtensa/platforms/iss/network.c
[]
> @@ -737,7 +737,7 @@ static int __init iss_net_setup(char *st
>  		return 1;
>  	}
>  
> -	if ((new = alloc_bootmem(sizeof new)) == NULL) {
> +	if ((new = alloc_bootmem(sizeof *new)) == NULL) {

sizeof(*new)

Please run coccinelle generated patches through checkpatch
(and the compiler of course) before submitting them.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/