linux-kernel - Re: [PATCH] irqchip: exynos-combiner: remove hard-coded irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 23 Sep 2013 17:30:37 +0530
From:	Chander Kashyap <chander.kashyap@...aro.org>
To:	Tomasz Figa <t.figa@...sung.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>,
	"kgene.kim@...sung.com" <kgene.kim@...sung.com>,
	tglx@...utronix.de, "thomas.ab@...sung.com" <thomas.ab@...sung.com>
Subject: Re: [PATCH] irqchip: exynos-combiner: remove hard-coded irq_base value

On 17 September 2013 18:07, Tomasz Figa <t.figa@...sung.com> wrote:
> Hi Chander,
>
> On Monday 16 of September 2013 11:01:22 Chander Kashyap wrote:
>> Pass '0' in place of hardcoded "irq_base" value as "first_irq" parameter
>> to "irq_domain_add_simple" in order to use linear irq domain.
>>
>> Signed-off-by: Chander Kashyap <chander.kashyap@...aro.org>
>> ---
>>  drivers/irqchip/exynos-combiner.c |   15 +++------------
>>  1 file changed, 3 insertions(+), 12 deletions(-)
>>
>> diff --git a/drivers/irqchip/exynos-combiner.c
>> b/drivers/irqchip/exynos-combiner.c index 4c68265..b4ed356 100644
>> --- a/drivers/irqchip/exynos-combiner.c
>> +++ b/drivers/irqchip/exynos-combiner.c
>> @@ -206,8 +206,7 @@ static unsigned int combiner_lookup_irq(int group)
>>
>>  static void __init combiner_init(void __iomem *combiner_base,
>>                                struct device_node *np,
>> -                              unsigned int max_nr,
>> -                              int irq_base)
>> +                              unsigned int max_nr)
>>  {
>>       int i, irq;
>>       unsigned int nr_irq;
>> @@ -221,7 +220,7 @@ static void __init combiner_init(void __iomem
>> *combiner_base, return;
>>       }
>>
>> -     combiner_irq_domain = irq_domain_add_simple(np, nr_irq, irq_base,
>> +     combiner_irq_domain = irq_domain_add_simple(np, nr_irq, 0,
>>                               &combiner_irq_domain_ops, combiner_data);
>
> I believe you can safely go with calling irq_domain_add_linear() directly
> here.

Yes, I will replace the call and resend the patch.

thanks
>
> Otherwise the patch looks good.
>
> Best regards,
> Tomasz
>



-- 
with warm regards,
Chander Kashyap
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/