linux-kernel - Re: [PATCH V2 12/18] regulator: max8952: use devm_regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 26 Sep 2013 15:41:32 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Mark Brown' <broonie@...nel.org>,
	'Sachin Kamat' <sachin.kamat@...aro.org>
Cc:	'Liam Girdwood' <lgirdwood@...il.com>,
	linux-kernel@...r.kernel.org, 'Milo Kim' <milo.kim@...com>,
	'Jingoo Han' <jg1.han@...sung.com>
Subject: Re: [PATCH V2 12/18] regulator: max8952: use devm_regulator_register()

On Thursday, September 26, 2013 11:10 AM, Jingoo Han wrote:
> 
> Use devm_regulator_register() to make cleanup paths simpler.
> 
> Signed-off-by: Jingoo Han <jg1.han@...sung.com>
> ---
>  drivers/regulator/max8952.c |    6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 

[.....]

> @@ -321,9 +322,6 @@ static int max8952_pmic_remove(struct i2c_client *client)
>  {
>  	struct max8952_data *max8952 = i2c_get_clientdata(client);
>  	struct max8952_platform_data *pdata = max8952->pdata;
> -	struct regulator_dev *rdev = max8952->rdev;
> -
> -	regulator_unregister(rdev);
> 
>  	gpio_free(pdata->gpio_vid0);
>  	gpio_free(pdata->gpio_vid1);

CC'ed Sachin Kamat,

Freeing the gpios before unregistering the device is not right,
even though it does not make the functional problems.
So, I will remove this patch from v3 patch series.

Best regards,
Jingoo Han

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/