linux-kernel - Re: [PATCH 16/27] mmc: mxcmmc: Move away from using deprecated APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 27 Sep 2013 09:19:37 +0200
From:	Sascha Hauer <s.hauer@...gutronix.de>
To:	Ulf Hansson <ulf.hansson@...aro.org>
Cc:	linux-kernel@...r.kernel.org, linux-mmc@...r.kernel.org,
	Chris Ball <cjb@...top.org>, Anatolij Gustschin <agust@...x.de>
Subject: Re: [PATCH 16/27] mmc: mxcmmc: Move away from using deprecated APIs

On Thu, Sep 26, 2013 at 04:54:41PM +0200, Ulf Hansson wrote:
> Suspend and resume of cards are being handled from the protocol layer
> and consequently the mmc_suspend|resume_host APIs are deprecated.
> 
> This means we can simplify the suspend|resume callbacks by removing the
> use of the deprecated APIs.
> 
> Cc: Sascha Hauer <s.hauer@...gutronix.de>
> Cc: Anatolij Gustschin <agust@...x.de>
> Signed-off-by: Ulf Hansson <ulf.hansson@...aro.org>

Acked-by: Sascha Hauer <s.hauer@...gutronix.de>

Sascha

> ---
>  drivers/mmc/host/mxcmmc.c |   12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/mmc/host/mxcmmc.c b/drivers/mmc/host/mxcmmc.c
> index c174c6a..f7199c8 100644
> --- a/drivers/mmc/host/mxcmmc.c
> +++ b/drivers/mmc/host/mxcmmc.c
> @@ -1250,28 +1250,20 @@ static int mxcmci_suspend(struct device *dev)
>  {
>  	struct mmc_host *mmc = dev_get_drvdata(dev);
>  	struct mxcmci_host *host = mmc_priv(mmc);
> -	int ret = 0;
>  
> -	if (mmc)
> -		ret = mmc_suspend_host(mmc);
>  	clk_disable_unprepare(host->clk_per);
>  	clk_disable_unprepare(host->clk_ipg);
> -
> -	return ret;
> +	return 0;
>  }
>  
>  static int mxcmci_resume(struct device *dev)
>  {
>  	struct mmc_host *mmc = dev_get_drvdata(dev);
>  	struct mxcmci_host *host = mmc_priv(mmc);
> -	int ret = 0;
>  
>  	clk_prepare_enable(host->clk_per);
>  	clk_prepare_enable(host->clk_ipg);
> -	if (mmc)
> -		ret = mmc_resume_host(mmc);
> -
> -	return ret;
> +	return 0;
>  }
>  
>  static const struct dev_pm_ops mxcmci_pm_ops = {
> -- 
> 1.7.9.5
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/